testsuite: Remove a GtkColorButton special case
authorTimm Bäder <mail@baedert.org>
Wed, 27 Jun 2018 15:58:01 +0000 (17:58 +0200)
committerTimm Bäder <mail@baedert.org>
Wed, 27 Jun 2018 16:03:23 +0000 (18:03 +0200)
The comment above explains neatly why subclassing GtkButton for
GtkColorButton was a bad idea. Nowadays it's a GtkWidget subclass
containing a GtkButton so let's remove the special case here.

testsuite/gtk/notify.c

index f36fefd471431d674f81732b85b0dce9b4fde7b1..950f2884ccf8c1e5bcb3a8c563ffe92e1f0666fc 100644 (file)
@@ -509,13 +509,6 @@ test_type (gconstpointer data)
          g_str_equal (pspec->name, "draw-indicator"))
         continue;
 
-      /* Really a bug in the way GtkButton and its subclasses interact:
-       * setting label etc on a subclass destroys the content, breaking
-       * e.g. GtkColorButton pretty badly
-       */
-      if (type == GTK_TYPE_COLOR_BUTTON && pspec->owner_type == GTK_TYPE_BUTTON)
-        continue;
-
       /* Too many special cases involving -set properties */
       if (g_str_equal (g_type_name (pspec->owner_type), "GtkCellRendererText") ||
           g_str_equal (g_type_name (pspec->owner_type), "GtkTextTag"))